[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Reply to: [list | sender only]
[ddlm-group] Better repository management
- To: ddlm-group <ddlm-group@iucr.org>
- Subject: [ddlm-group] Better repository management
- From: James Hester <jamesrhester@gmail.com>
- Date: Tue, 1 Sep 2020 16:37:37 +1000
Hi all,
I propose improving the way our Github repositories are managed. In the past, we have been discussing changes in this group, and then typically I would edit in the changes. Smaller technical matters are dealt with by Github issues.
What I propose going forward is that changes to the dictionaries come in by way of a Github pull request.Ā Of course, if a policy issue is involved, then that would be discussed in this group first and/or in the Github issues tracker, before a pull request is generated to resolve the issue. Ideally a pull request would be merged after a review period by someone other than the person generating the pull request. Given this double-check, and the safety of version control, I think we should open up commit rights to a broader group of people. If you agree and have a Github login, please let me know your Github login and I'll add you to the repository.
So: you will see atĀ https://github.com/COMCIFS/cif_core/pulls two pull requests to satisfy the resolution of the dictionary_xref issue from messageĀ https://www.iucr.org/__data/iucr/lists/ddlm-group/msg01561.html
I will leave these pull requests available for a week or so in case anybody has technical comments, and then I guess I'll poke somebody to merge them.
all the best,
James.
PS For those not familiar with how pull requests work, typically if you have a change to make to some project, you fork the relevant project to your own Github area (there is a 'fork' button at top right), edit and commit in your area, and then create a pull request to commit the changes back to the COMCIFS repository. Pull requests seem to work best if you create a new branch for your edits in your area, which you can later delete.
--
--
T +61 (02) 9717 9907
F +61 (02) 9717 3145
M +61 (04) 0249 4148
F +61 (02) 9717 3145
M +61 (04) 0249 4148
_______________________________________________ ddlm-group mailing list ddlm-group@iucr.org http://mailman.iucr.org/cgi-bin/mailman/listinfo/ddlm-group
Reply to: [list | sender only]
- Prev by Date: Re: [ddlm-group] Preparing CIF for multi-block datasets
- Next by Date: [ddlm-group] A rationalisation of DDLm
- Prev by thread: Re: [ddlm-group] A rationalisation of DDLm
- Next by thread: [ddlm-group] Making ddl2 <-> ddlm translation a reality
- Index(es):