Discussion List Archives

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: _item_related.function_code

Hi John,

We will correct the inconsistent use of 'replaces' when the dictionary is next updated.

Thanks for pointing out the problem.


On 6/14/10 11:26 AM, Bollinger, John C wrote:
> Dear Richard,
> I read DDL2 and the mmCIF dictionary the same way you do.  In the scope of the definition of _atom_site.refinement_flags, the defined item is _atom_site.refinement_flags, so the dictionary fragment you presented says that _atom_site.refinement_flags replaces each of _atom_site.refinement_flags_adp, _atom_site.refinement_flags_occupancy, and _atom_site.refinement_flags_posn, which is inconsistent with the definitions of the corresponding Core dictionary items.  One cannot simply argue that we are reading DDL2 wrongly, for the current mmCIF dictionary uses the related item feature inconsistently.  Items _diffrn_reflns_class.av_sgI/I and _reflns_shell.meanI_over_sigI_gt use the 'replaces' code in the same sense that _atom_site.refinement_flags does, but items _database_2.database_id and _database_2.database_code use it in the opposite sense (consistent with the DDL2 bit you cited).  There are no uses of "replacedby" and no other uses of "replaces" in the current mmCIF dictiona
>   .
> One group of definitions or the other must be erroneous.  Inasmuch as mmCIF attempts to be consistent with the Core dictionary, I think it is safe to assume that it is the definitions of _atom_site.refinement_flags, _diffrn_reflns_class.av_sgI/I, and _reflns_shell.meanI_over_sigI_gt that are wrong.  The corresponding DDL1 feature for related items uses code 'replace' for what DDL2 calls 'replacedby': "'replace' signals that the item referred to in _related_item may be used identically to replace the defined item."  All of the erroneous mmCIF definitions are drawn from the Core, so perhaps the errors arise from faulty machine translation of the Core dictionary ('replace' -->  'replaces' instead of 'replace' -->  'replacedby').
> I'm not sure who is responsible for mmCIF dictionary maintenance, but there are others listening to this list who do.  That's where this needs to go.
> Best Regards,
> John
> --
> John C. Bollinger, Ph.D.
> Department of Structural Biology
> St. Jude Children's Research Hospital
> On Monday, June 14, 2010 7:07 AM, Richard Gildea wrote:
>> I have query regarding the _item_related.function_code definitions and their use in item definitions.
>> The descriptions for the 'replaces' and 'replacedby' value for _item_related.function_code are:
>> "REPLACES  indicates that the defined item replaces the item identified in _item_related.related_name."
>> and
>> "REPLACEDBY  indicates that the defined item is replaced by the item identified in  _item_related.related_name."
>> From the _atom_site.refinement_flags definition in cif_mm.dic these items are defined as follows:
>>     loop_
>>      _item_related.related_name
>>      _item_related.function_code
>>                                '_atom_site.refinement_flags_posn'      replaces
>>                                '_atom_site.refinement_flags_adp'       replaces
>>                                '_atom_site.refinement_flags_occupancy' replaces
>> From the above definitions, I would take this to mean that _atom_site.refinement_flags ("the defined item") replaces the three items *_posn, *_adp, *_occupancy ("the items identified in _item_related.related_name").
>> This interpretation is clearly at odds with the associated description which says
>> "It has been replaced by _atom_site.refinement_flags_posn, *_adp and *_occupancy".
>> Either my interpretation of the DDL2 definitions is wrong, or I suspect that it is "replacedby" which should be used here, and not "replaces". In fact the only occurrences of "replacedby" in cif_mm.dic are in commented out definitions.
> Email Disclaimer:  www.stjude.org/emaildisclaimer
> _______________________________________________
> cif-developers mailing list
> cif-developers@iucr.org
> http://scripts.iucr.org/mailman/listinfo/cif-developers

   John Westbrook, Ph.D.
   Rutgers, The State University of New Jersey
   Department of Chemistry and Chemical Biology
   610 Taylor Road
   Piscataway, NJ 08854-8087
   e-mail: jwest@rcsb.rutgers.edu
   Ph:  (732) 445-4290  Fax: (732) 445-4320
cif-developers mailing list

Reply to: [list | sender only]
International Union of Crystallography

Scientific Union Member of the International Science Council (admitted 1947). Member of CODATA, the ISC Committee on Data. Partner with UNESCO, the United Nations Educational, Scientific and Cultural Organization in the International Year of Crystallography 2014.

International Science Council Scientific Freedom Policy

The IUCr observes the basic policy of non-discrimination and affirms the right and freedom of scientists to associate in international scientific activity without regard to such factors as ethnic origin, religion, citizenship, language, political stance, gender, sex or age, in accordance with the Statutes of the International Council for Science.