[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
--
Reply to: [list | sender only]
Re: [ddlm-group] Removing separate "Count" and "Index" types from_type.contents in DDLm
- To: "Herbert J. Bernstein" <yayahjb@gmail.com>
- Subject: Re: [ddlm-group] Removing separate "Count" and "Index" types from_type.contents in DDLm
- From: James Hester <jamesrhester@gmail.com>
- Date: Wed, 25 Sep 2019 11:45:47 +1000
- Cc: Group finalising DDLm and associated dictionaries <ddlm-group@iucr.org>
- In-Reply-To: <CABcsX25StOtQ12ioJhd3GTh8R+JYgVUdvwUCB299ZUB7pAEvBA@mail.gmail.com>
- References: <CAM+dB2dOXZk-6ZsmLcCcM=pORcAr4VRLAie_BbDxbBK9jM7zYg@mail.gmail.com><CABcsX25StOtQ12ioJhd3GTh8R+JYgVUdvwUCB299ZUB7pAEvBA@mail.gmail.com>
There having been no objections to Herbert's comment, I will raise an issue to mark "Count" and "Index" as deprecated, *after* changing all official dictionaries to use "Integer" and set the enumeration range accordingly.
On Tue, 23 Jul 2019 at 12:32, Herbert J. Bernstein <yayahjb@gmail.com> wrote:
The most you could do safely is to deprecate, not remove Count and Index, since we have no way to know how many, if any, uses have been made of Count and Index, and I cannot see what is gained by removing or deprecatingthem. I would agree that is would make sense to take the small step of checking each use of Count or Indexand seeing how the those uses would look if CIF base types were used. If we were to end up with no IUCr official uses of Count and Index, then we could explore deprecating one or the other. Removing them abruptly wouldbe a mistake.Regards,HerbertOn Mon, Jul 22, 2019 at 9:32 PM James Hester <jamesrhester@gmail.com> wrote:Dear DDLm experts,_______________________________________________A suggestion has been made (see https://github.com/COMCIFS/cif_core/issues/140) that we do not need all of "Count", "Index" and "Integer" types in the list of possible values for _type.contents. "Count" is an unsigned integer, "Index" is a non-zero unsigned integer, and "Integer" is ... an integer. We have _enumeration.range which allows us to specify the lower limit of a value, and so "Integer" in combination with this is sufficient to exactly cover both "Count" and "Index". Does anybody see a problem with removing "Count" and "Index"?thanks,James.
--T +61 (02) 9717 9907
F +61 (02) 9717 3145
M +61 (04) 0249 4148
ddlm-group mailing list
ddlm-group@iucr.org
http://mailman.iucr.org/cgi-bin/mailman/listinfo/ddlm-group
T +61 (02) 9717 9907
F +61 (02) 9717 3145
M +61 (04) 0249 4148
F +61 (02) 9717 3145
M +61 (04) 0249 4148
_______________________________________________ ddlm-group mailing list ddlm-group@iucr.org http://mailman.iucr.org/cgi-bin/mailman/listinfo/ddlm-group
Reply to: [list | sender only]
- References:
- Prev by Date: Re: [ddlm-group] Removing separate "Count" and "Index" types from_type.contents in DDLm
- Next by Date: [ddlm-group] Handling of missing and null in dREL
- Prev by thread: Re: [ddlm-group] Removing separate "Count" and "Index" types from_type.contents in DDLm
- Next by thread: [ddlm-group] Adding a DDLm attribute for uniqueness
- Index(es):