[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Reply to: [list | sender only]
Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
- To: <imgcif-l@iucr.org>, <nksauter@lbl.gov>
- Subject: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
- From: <Graeme.Winter@Diamond.ac.uk>
- Date: Thu, 18 Feb 2010 15:50:07 -0000
- In-Reply-To: <a06240802c7a26e7f3e21@[192.168.2.104]>
- References: <4854F2500EA8C4478A508D2D92973E5206D6B2EA@EXCHANGE25.fed.cclrc.ac.uk><alpine.BSF.2.00.1002160753380.66907@epsilon.pair.com><279aad2a1002161513h77b926b1y239ee4192442e55b@mail.gmail.com><4854F2500EA8C4478A508D2D92973E5206D6B2FE@EXCHANGE25.fed.cclrc.ac.uk><4B7BB2E6.5060101@esrf.fr><alpine.BSF.2.00.1002170731330.22889@epsilon.pair.com><4B7C3E49.5090905@lbl.gov><a06240802c7a26e7f3e21@[192.168.2.104]>
Dear Herbert, Surely it would be relatively straightforward to "fake" some pathalogical images for the purposes of testing, i.e. set values of 0xffff, 0x0000, 0xffff, 0x0000 &c. in a "C" array and compress this to a CBF stream? As you could have a valid CBF 128 x 128 pixels (say) it needn't be that large even... If I get a quiet moment I'll code something up. Best wishes, Graeme -----Original Message----- From: imgcif-l-bounces@iucr.org [mailto:imgcif-l-bounces@iucr.org] On Behalf Of Herbert J. Bernstein Sent: 18 February 2010 04:21 To: Nicholas K. Sauter Cc: imgcif-l@iucr.org Subject: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c Dear Nick, You are absolutely right. I am also having trouble working up a test case. It needs an image with a very large negative delta. I'll try to force something. In the meantime, I have updated the sourceforge cbflib svn with the fix in CBFlib_bleeding_edge. After I have a test case, I'll propagate the change more widely. I am copying this to the imgCIF list to warn others in the meantime. Thank you very much. Well done. Regards, Herbert At 11:06 AM -0800 2/17/10, Nicholas K. Sauter wrote: >Herbert, > >Please see line 1166 in src/cbf_byte_offset.c. > >Based on the logic of the algorithm I think this line should be > >if (delta[0] & 0x8000) { > >i.e., there is an extra "0" in the hex value in the CVS code. >That being said, I don't think this line has an effect on any of my >test cases, so I'm at a loss about how to test this out. > >Nick -- ===================================================== Herbert J. Bernstein, Professor of Computer Science Dowling College, Kramer Science Center, KSC 121 Idle Hour Blvd, Oakdale, NY, 11769 +1-631-244-3035 yaya@dowling.edu ===================================================== _______________________________________________ imgcif-l mailing list imgcif-l@iucr.org http://scripts.iucr.org/mailman/listinfo/imgcif-l -- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom _______________________________________________ imgcif-l mailing list imgcif-l@iucr.org http://scripts.iucr.org/mailman/listinfo/imgcif-l
Reply to: [list | sender only]
- References:
- [Imgcif-l] ... also (Graeme.Winter)
- Re: [Imgcif-l] ... also (Herbert J. Bernstein)
- Re: [Imgcif-l] ... also (James Hester)
- Re: [Imgcif-l] ... also (Graeme.Winter)
- Re: [Imgcif-l] ... also (Jon Wright)
- Re: [Imgcif-l] ... also (Herbert J. Bernstein)
- Re: [Imgcif-l] Possible bug in cbf_byte_offset.c (Herbert J. Bernstein)
- Prev by Date: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
- Next by Date: Re: [Imgcif-l] Fwd: Re: Possible bug in cbf_byte_offset.c
- Prev by thread: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
- Next by thread: Re: [Imgcif-l] ... also
- Index(es):