[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Reply to: [list | sender only]
Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
- To: "Nicholas K. Sauter" <nksauter@lbl.gov>
- Subject: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
- From: "Herbert J. Bernstein" <yaya@bernstein-plus-sons.com>
- Date: Wed, 17 Feb 2010 23:21:01 -0500
- Cc: imgcif-l@iucr.org
- In-Reply-To: <4B7C3E49.5090905@lbl.gov>
- References: <4854F2500EA8C4478A508D2D92973E5206D6B2EA@EXCHANGE25.fed.cclrc.ac.uk><alpine.BSF.2.00.1002160753380.66907@epsilon.pair.com><279aad2a1002161513h77b926b1y239ee4192442e55b@mail.gmail.com><4854F2500EA8C4478A508D2D92973E5206D6B2FE@EXCHANGE25.fed.cclrc.ac.uk><4B7BB2E6.5060101@esrf.fr><alpine.BSF.2.00.1002170731330.22889@epsilon.pair.com><4B7C3E49.5090905@lbl.gov>
Dear Nick, You are absolutely right. I am also having trouble working up a test case. It needs an image with a very large negative delta. I'll try to force something. In the meantime, I have updated the sourceforge cbflib svn with the fix in CBFlib_bleeding_edge. After I have a test case, I'll propagate the change more widely. I am copying this to the imgCIF list to warn others in the meantime. Thank you very much. Well done. Regards, Herbert At 11:06 AM -0800 2/17/10, Nicholas K. Sauter wrote: >Herbert, > >Please see line 1166 in src/cbf_byte_offset.c. > >Based on the logic of the algorithm I think this line should be > >if (delta[0] & 0x8000) { > >i.e., there is an extra "0" in the hex value in the CVS code. >That being said, I don't think this line has an effect on any of my >test cases, so I'm at a loss about how to test this out. > >Nick -- ===================================================== Herbert J. Bernstein, Professor of Computer Science Dowling College, Kramer Science Center, KSC 121 Idle Hour Blvd, Oakdale, NY, 11769 +1-631-244-3035 yaya@dowling.edu ===================================================== _______________________________________________ imgcif-l mailing list imgcif-l@iucr.org http://scripts.iucr.org/mailman/listinfo/imgcif-l
Reply to: [list | sender only]
- Follow-Ups:
- Re: [Imgcif-l] Possible bug in cbf_byte_offset.c (Graeme.Winter)
- References:
- [Imgcif-l] ... also (Graeme.Winter)
- Re: [Imgcif-l] ... also (Herbert J. Bernstein)
- Re: [Imgcif-l] ... also (James Hester)
- Re: [Imgcif-l] ... also (Graeme.Winter)
- Re: [Imgcif-l] ... also (Jon Wright)
- Re: [Imgcif-l] ... also (Herbert J. Bernstein)
- Prev by Date: Re: [Imgcif-l] ... also
- Next by Date: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
- Prev by thread: Re: [Imgcif-l] ... also
- Next by thread: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
- Index(es):